[webkit-reviews] review granted: [Bug 78740] Made Weak<T> single-owner, adding PassWeak<T> : [Attachment 127241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 15:51:13 PST 2012


Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 78740: Made Weak<T> single-owner, adding PassWeak<T>
https://bugs.webkit.org/show_bug.cgi?id=78740

Attachment 127241: Patch
https://bugs.webkit.org/attachment.cgi?id=127241&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
One idiom we have been adopting with other smart pointers in WebKit is that you
never explicitly construct the Pass type, but rather have a friend function
that does it, e.g. adoptPtr() and adoptRef().  Not sure that is necessary here
but wanted to mention it.


More information about the webkit-reviews mailing list