[webkit-reviews] review granted: [Bug 78751] Add support for the translate attribute in html elements. : [Attachment 127249] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 78751: Add support for the translate attribute in html elements.
https://bugs.webkit.org/show_bug.cgi?id=78751

Attachment 127249: Patch
https://bugs.webkit.org/attachment.cgi?id=127249&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127249&action=review


Is there any more to this attribute?  A link to the spec would be helpful so I
can read up on it easily.  Some nits below.

> Source/WebCore/ChangeLog:8
> +	   Add support for the translate attribute in html elements.
> +	   https://bugs.webkit.org/show_bug.cgi?id=78751
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: fast/dom/HTMLElement/translate.html

Can you add some more information to the ChangeLog, like a link to the spec?

> Source/WebCore/html/HTMLElement.cpp:823
> +	       if (mode != TranslateAttributeInherit)
> +		   return mode == TranslateAttributeYes;

Should we ASSERT that the mode is either TranslateAttributeYes or
TranslateAttributeNo in the body of this if?