[webkit-reviews] review granted: [Bug 74858] chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV at NULL (e85cb8e140071fa7790cad215b0109dc) : [Attachment 127225] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Florin Malita
<fmalita at google.com>'s request for review:
Bug 74858: chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV at NULL
(e85cb8e140071fa7790cad215b0109dc)
https://bugs.webkit.org/show_bug.cgi?id=74858

Attachment 127225: Patch
https://bugs.webkit.org/attachment.cgi?id=127225&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127225&action=review


Looks just great! r=me.

> Source/WebCore/svg/SVGTRefElement.cpp:185
> +    Node* container = shadowRootList()->oldestShadowRoot()->firstChild();

oldestShadowRoot, and shadowRootList are guaranteed non-null?
If yes, there's nothing hold back a cq+.