[webkit-reviews] review requested: [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units : [Attachment 127238] Patch-BasedOn-Antti's Review Comments

[bugzilla-daemon at webkit.org]

Joe Thomas <joethomas at motorola.com> has asked  for review:
Bug 27160: Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

Attachment 127238: Patch-BasedOn-Antti's Review Comments
https://bugs.webkit.org/attachment.cgi?id=127238&action=review

------- Additional Comments from Joe Thomas <joethomas at motorola.com>
Patch based on Antti Koivisto's review comments

Included viewportSize as one of the parameter in the getter functions of Length
structure (calcValue, calcMinValue, calcFloatValue) with a default value
IntSize().

Currently, the viewportSize parameter is used only when the width and height is
calculated in RenderBox. Length getters are used extensively in webCore. I
think it is better to include the viewport parameter in other places on a need
basis. Any thoughts on this?