[webkit-reviews] review granted: [Bug 78554] Refactor ClipboardMac class to use PlatformStrategies : [Attachment 126872] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 78554: Refactor ClipboardMac class to use PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=78554

Attachment 126872: Patch
https://bugs.webkit.org/attachment.cgi?id=126872&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126872&action=review


> Source/WebCore/platform/PasteboardStrategy.h:46
> +    virtual const String uniqueName() = 0;

This doesn't need to return a const String.

> Source/WebCore/platform/PlatformPasteboard.h:43
> +    static const String uniqueName();

Ditto.

> Source/WebCore/platform/PlatformPasteboard.h:49
> +    int changeCount();

Can this member function be const?

> Source/WebCore/platform/mac/ClipboardMac.mm:73
> +static const String cocoaTypeFromHTMLClipboardType(const String& type)

No need for const.