[webkit-reviews] review granted: [Bug 77125] [chromium] Add setter/getter to expose drag data as a list of items : [Attachment 125678] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 77125: [chromium] Add setter/getter to expose drag data as a list of items
https://bugs.webkit.org/show_bug.cgi?id=77125

Attachment 125678: Patch
https://bugs.webkit.org/attachment.cgi?id=125678&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125678&action=review


> Source/WebKit/chromium/public/platform/WebDragData.h:60
> +	   // There are three different types of data we store in Item nodes:

nit: I'd probably just make these comments above each enum value.

  enum StorageType {
      // Blah, blah, blah
      StorageTypeString,

      // Blah, blah, blah
      StorageTypeFilename,

      ...
  };

This way it is a bit less verbose as you don't need to repeat the enum value
name.