[webkit-reviews] review denied: [Bug 78526] Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout : [Attachment 126834] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 78526: Convert RenderFrameSet to LayoutUnits in preparation for turning on
subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78526

Attachment 126834: Patch
https://bugs.webkit.org/attachment.cgi?id=126834&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review


> Source/WebCore/rendering/RenderFrameSet.cpp:85
> +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const
IntRect& borderRect)
>  {
> -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> +    if (!paintInfo.rect.intersects(borderRect))

Why is this one ints?

> Source/WebCore/rendering/RenderFrameSet.cpp:103
>  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const
LayoutRect& borderRect)

Did you intentionally leave this one LayoutRects?

> Source/WebCore/rendering/RenderFrameSet.h:122
> +    void paintRowBorder(const PaintInfo&, const IntRect&);

This doesn't match the cpp side of your change.