[webkit-reviews] review granted: [Bug 76326] getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value : [Attachment 127209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 12:05:29 PST 2012


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76326: getComputedStyle of flex-item-align:auto should resolve to it's
parent's flex-align value
https://bugs.webkit.org/show_bug.cgi?id=76326

Attachment 127209: Patch
https://bugs.webkit.org/attachment.cgi?id=127209&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127209&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1587
> +	       if (m_node && m_node->parentNode() &&
m_node->parentNode()->computedStyle() && style->flexItemAlign() == AlignAuto)

I would put the style->flexItemAlign() == AlignAuto check first so we don't do
all the other checks for other alignments.


More information about the webkit-reviews mailing list