[webkit-reviews] review canceled: [Bug 78638] Don't clear IntentRequest callback pointers on stop() : [Attachment 127201] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has canceled Greg Billock
<gbillock at google.com>'s request for review:
Bug 78638: Don't clear IntentRequest callback pointers on stop()
https://bugs.webkit.org/show_bug.cgi?id=78638

Attachment 127201: Patch
https://bugs.webkit.org/attachment.cgi?id=127201&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127201&action=review


> LayoutTests/webintents/resources/web-intents-reload-new.html:6
> +	 window.setTimeout(1000, function() {
> +	   });

This is probably not the right way to test this.

> LayoutTests/webintents/web-intents-reload.html:20
> +	   window.setTimeout(1000, function() {
> +	     debug("* survived");
> +	   });

You shouldn't need any timeouts.  Maybe try using an iframe and triggering the
crash in side the iframe.  You can have the parent frame grab a pointer to the
iframe's document to prevent the document from getting deleted while the test
is running.