[webkit-reviews] review granted: [Bug 78719] [GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate : [Attachment 127188] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 78719: [GTK] Document that local paths in html loaded with loadHTML might
cause the web process to terminate
https://bugs.webkit.org/show_bug.cgi?id=78719

Attachment 127188: Patch
https://bugs.webkit.org/attachment.cgi?id=127188&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127188&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:890
> + * must be in the same directory than @base_uri. Asbolute local paths
pointing to a
> + * different directory than @base_uri will cause the web process to
terminate.
> + * If you need to include URLs in @content that are local paths in a
different
> + * directory than @base_uri you can build a data uri for them. When
@base_uri is %NULL,

Would a phrase like "Absolute local paths must be children of the @base_uri" be
clearer? You might mention that this is for security reasons specifically.
Asbolute -> Absolute :)