[webkit-reviews] review requested: [Bug 78389] wtf/ThreadingWin.cpp doesn't build for 64-bit Windows : [Attachment 127149] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 15 03:09:29 PST 2012
Kalev Lember <kalevlember at gmail.com> has asked for review:
Bug 78389: wtf/ThreadingWin.cpp doesn't build for 64-bit Windows
https://bugs.webkit.org/show_bug.cgi?id=78389
Attachment 127149: Patch v2
https://bugs.webkit.org/attachment.cgi?id=127149&action=review
------- Additional Comments from Kalev Lember <kalevlember at gmail.com>
This patch implements the WTF threading API change and fixes up all client
code. For Safari that uses the internal WTF threading API directly, I've also
kept ABI-compatibility, so binaries should keep working without a rebuild. (It
will still have to cope with the API change.)
Instead of changing the signature of ThreadFunction to return unsigned, I
changed it to return void. The return value wasn't getting used anywhere, so by
eliminating it, I could clean up the client code a bit.
More information about the webkit-reviews
mailing list