[webkit-reviews] review denied: [Bug 78679] Clean up radio button tests : [Attachment 127130] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 78679: Clean up radio button tests
https://bugs.webkit.org/show_bug.cgi?id=78679

Attachment 127130: Patch
https://bugs.webkit.org/attachment.cgi?id=127130&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127130&action=review


r- due to missing the diff of radio-nested-labels.html

> LayoutTests/ChangeLog:9
> +	   - Split checkbox-radio-onchange.html into two.
> +	   - Convert some rendering tests about radio buttons to text tests.

Maybe I wanted to see more descriptive comments. At least,

- Split checkbox-radio-onchange.html into checkbox-onchange.html and
radio-onchange.html.
- Convert radio_checked.html and radio_checked_dynamic.html to text tests.

> LayoutTests/ChangeLog:19
> +	   * fast/forms/radio-nested-labels.html:

This change is recognized as a binary change and I cannot see it. Would you
paste the diff in comments?

> LayoutTests/fast/forms/radio-attr-order.html:6
> +<input type="radio" checked name="test_group" id="rb">

Nit: name= is not necessary.

> LayoutTests/fast/forms/radio/radio-onchange.html:7
> +<input type="radio" name="test" id="rd">

Nit: You can remove this line.

> LayoutTests/fast/forms/radio/radio-onchange.html:8
> +<input type="radio" name="test" id="rd2" onchange="handleChange()">

Nit: name= is not necessary.