[webkit-reviews] review granted: [Bug 78503] Web Inspector: [InspectorIndexedDB] Pass data entries from object stores and indexes to front-end. : [Attachment 126981] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 14 23:16:12 PST 2012
Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 78503: Web Inspector: [InspectorIndexedDB] Pass data entries from object
stores and indexes to front-end.
https://bugs.webkit.org/show_bug.cgi?id=78503
Attachment 126981: Patch
https://bugs.webkit.org/attachment.cgi?id=126981&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126981&action=review
> Source/WebCore/inspector/InjectedScript.cpp:181
> + ScriptValue scriptValue =
serializedScriptValue->deserializeForInspector(m_injectedScriptObject.scriptSta
te());
Can deserialization fail? If so, we should check for an empty scriptValue here
to avoid crash.
More information about the webkit-reviews
mailing list