[webkit-reviews] review denied: [Bug 78660] [BlackBerry] Upstream WebPageClient.h : [Attachment 127101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 19:17:28 PST 2012


Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 78660: [BlackBerry] Upstream WebPageClient.h
https://bugs.webkit.org/show_bug.cgi?id=78660

Attachment 127101: Patch
https://bugs.webkit.org/attachment.cgi?id=127101&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127101&action=review


Looks good, but still some things to fix.

> Source/WebKit/blackberry/Api/WebPageClient.h:32
> +#include <BlackBerryPlatformWindow.h>

Are all of the above needed?

> Source/WebKit/blackberry/Api/WebPageClient.h:34
> +#include <pthread.h>

Does not seem needed?

> Source/WebKit/blackberry/Api/WebPageClient.h:45
> +class GeoTracker;

Not needed?


More information about the webkit-reviews mailing list