[webkit-reviews] review denied: [Bug 78449] [WebSocket] Add deflater/inflater classes : [Attachment 126952] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 78449: [WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449

Attachment 126952: Patch
https://bugs.webkit.org/attachment.cgi?id=126952&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126952&action=review


> Source/WebCore/websockets/WebSocketDeflater.cpp:178
> +    static const char strippedFields[] = {0x00, 0x00, 0xff, 0xff};

Windows EWS is red.

3>..\websockets\WebSocketDeflater.cpp(178) : error C2220: warning treated as
error - no 'object' file generated
3>..\websockets\WebSocketDeflater.cpp(178) : warning C4309: 'initializing' :
truncation of constant value
3>..\websockets\WebSocketDeflater.cpp(178) : warning C4309: 'initializing' :
truncation of constant value