[webkit-reviews] review granted: [Bug 78644] [BlackBerry] Upstream remaining classes in Api : [Attachment 127065] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 78644: [BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644

Attachment 127065: Patch
https://bugs.webkit.org/attachment.cgi?id=127065&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127065&action=review


BlackBerryContext is a very general name, lets keep it in mind for the future
:)

> Source/WebKit/blackberry/Api/BlackBerryGlobal.h:28
> +#ifdef _MSC_VER
> +    #ifdef BUILD_WEBKIT
> +	   #define BLACKBERRY_EXPORT __declspec(dllexport)
> +    #else
> +	   #define BLACKBERRY_EXPORT __declspec(dllimport)
> +    #endif
> +#elif defined(__QNXNTO__) && defined(BUILD_WEBKIT)

do we really care?

> Source/WebKit/blackberry/Api/BlackBerryGlobal.h:32
> +#else
> +    #define BLACKBERRY_EXPORT
> +#endif

ditto