[webkit-reviews] review denied: [Bug 78633] [BlackBerry] Upstreaming WebSettings code : [Attachment 127049] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 78633: [BlackBerry] Upstreaming WebSettings code
https://bugs.webkit.org/show_bug.cgi?id=78633

Attachment 127049: Patch
https://bugs.webkit.org/attachment.cgi?id=127049&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127049&action=review


> Source/WebKit/blackberry/Api/WebSettings.cpp:29
> +#include <wtf/Vector.h>

Are all these needed?

> Source/WebKit/blackberry/Api/WebSettings.cpp:590
> +// Whether to include pattern: in the list of string patterns

period.

> Source/WebKit/blackberry/Api/WebSettings.h:51
> +    WebSettings(const WebSettings&);

More common to put private section at the end.

> Source/WebKit/blackberry/Api/WebSettings_p.h:25
> +#include <wtf/text/StringHash.h>

Needed?

> Source/WebKit/blackberry/Api/WebSettings_p.h:67
> +	   WTF::HashMap<WTF::String, PrimitiveValue> primitiveValues;

You do not need WTF prefix on HashMap.