[webkit-reviews] review granted: [Bug 78566] [CMake] Merge WebKitEfl.cmake into FindEFL.cmake. : [Attachment 126890] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 15:16:02 PST 2012


Daniel Bates <dbates at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 78566: [CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78566

Attachment 126890: Patch
https://bugs.webkit.org/attachment.cgi?id=126890&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126890&action=review


> Source/cmake/FindEFL.cmake:19
> +    MESSAGE(FATAL_ERROR "edje_cc could not be found")

Nit: Should there be a space between MESSAGE and '('? We seem to be
inconsistent throughout the CMake build system with respect to our function
call notation.


More information about the webkit-reviews mailing list