[webkit-reviews] review denied: [Bug 78390] Web Inspector: Switch Debugger agent to TypeBuilder : [Attachment 127048] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 14 15:09:01 PST 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 78390: Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390
Attachment 127048: Patch
https://bugs.webkit.org/attachment.cgi?id=127048&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127048&action=review
> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:324
> + using WebCore::TypeBuilder::Debugger::Location;
Why isn't this statement at the beginning of the file?
This seems to be forbidden by style guide and you need to use a long name for
return value type because of that.
More information about the webkit-reviews
mailing list