[webkit-reviews] review granted: [Bug 78622] IndexedDB: Invalid dates should not be valid keys : [Attachment 127011] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 14 13:16:31 PST 2012
Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 78622: IndexedDB: Invalid dates should not be valid keys
https://bugs.webkit.org/show_bug.cgi?id=78622
Attachment 127011: Patch
https://bugs.webkit.org/attachment.cgi?id=127011&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127011&action=review
> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:49
> - if (value->IsDate())
> + if (value->IsDate() && !isnan(value->NumberValue()))
Should this file explicitly include wtf/MthExtras.h for isnan? It looks like
this code already uses it.
More information about the webkit-reviews
mailing list