[webkit-reviews] review denied: [Bug 78615] Initial upstreaming for find-in-page for BlackBerry port : [Attachment 127009] Initial upstreaming for find-in-page for BlackBerry

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Andy Chen <andchen at rim.com>'s request
for review:
Bug 78615: Initial upstreaming for find-in-page for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78615

Attachment 127009: Initial upstreaming for find-in-page for BlackBerry
https://bugs.webkit.org/attachment.cgi?id=127009&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127009&action=review


Some stuff still needs to be fixed.

> Source/WebKit/ChangeLog:5
> +

Maybe add an explanation why this change is made.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.h:41
> +    bool findNextString(const WTF::String& text, bool forward);

I dont think you need the WTF:: prefix.