[webkit-reviews] review denied: [Bug 20181] font shorthand with inherit keyword incorrectly parsed and rendered : [Attachment 126809] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 20181: font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181

Attachment 126809: Patch
https://bugs.webkit.org/attachment.cgi?id=126809&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126809&action=review


> Source/WebCore/css/CSSParser.cpp:4303
> +	   if (value->id == CSSValueInitial || value->id == CSSValueInherit)
> +	       return list.release();

Is this correct?  It looks like it's possible for list to have values appended
to it that are returned.  Can you add some tests that just set font family
directly?

> LayoutTests/fast/css/font-shorthand-mix-inherit.html:29
> +    test.style.font = "12pt/14pt inherit";
> +    shouldBe("test.style.getPropertyValue('font')", "''");

Can you also add a test for "inherit sans-serif"?

> LayoutTests/fast/css/font-shorthand-mix-inherit.html:36
> +    test.style.font = "x-large/110% \"new century schoolbook\", serif,
inherit";

Nit: Use '' so you don't have to escape the "s.