[webkit-reviews] review denied: [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors : [Attachment 126910] Fixed build errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 11:20:58 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 9767: WebPreference methods setAllowsAnimatedImages: and
setAllowsAnimatedImageLooping: don't actually affect WebView behaviors
https://bugs.webkit.org/show_bug.cgi?id=9767

Attachment 126910: Fixed build errors
https://bugs.webkit.org/attachment.cgi?id=126910&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126910&action=review


> Source/WebKit/chromium/public/WebSettings.h:70
> +    virtual void setAllowsAnimatedImages(bool) = 0;

nit: this should probably be "setAllowAnimatedImages" instead.	this matches
other similarly named functions.  i think you should make this change to
WebCore::Settings too.


More information about the webkit-reviews mailing list