[webkit-reviews] review granted: [Bug 78447] Web Inspector: open the inspector while on Kickstarter.com shows fonts that are not used : [Attachment 126978] Proposed Change

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 78447: Web Inspector: open the inspector while on Kickstarter.com shows
fonts that are not used
https://bugs.webkit.org/show_bug.cgi?id=78447

Attachment 126978: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=126978&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126978&action=review


> LayoutTests/ChangeLog:10
> +	   * inspector/protocol/page-agent-expected.txt: Updated.

It would be nice to state a little more clearly here what is being updated
about the test, because it is a bit confusing from the diff. The fact that
there is another font shown in the results that was loaded would be good to
mention.

> Source/WebCore/inspector/InspectorPageAgent.cpp:412
>	   result.append(it->second.get());

This should just use cachedResource.