[webkit-reviews] review granted: [Bug 78582] Finish implementing start_helper for ChromiumAndroidPort : [Attachment 126917] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 78582: Finish implementing start_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78582

Attachment 126917: Patch
https://bugs.webkit.org/attachment.cgi?id=126917&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126917&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:315
> +	   except:
> +	       # Reset to 1970-01-01 00:00:00 UTC.
> +	       host_datetime = 0

I wonder if anyone has ever used this except: path... I doubt it works.  I'm
not sure having an except here is helpful.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:326
> +    def _run_adb_command(self, cmd, ignore_error=False):

IT seems ignore_error=true is never used.