[webkit-reviews] review denied: [Bug 78599] Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel : [Attachment 126965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 05:44:28 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 78599: Web Inspector: [refactoring] extract TimelineOverviewWindow from
TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599

Attachment 126965: Patch
https://bugs.webkit.org/attachment.cgi?id=126965&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126965&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:255
> +	       if (node.hasStyleClass("resources-dividers-label-bar")) {

Why did this change?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:-264
> -	       if (this._overviewGrid.itemsGraphsElement.offsetWidth -
window.end > WebInspector.TimelineOverviewPane.MinSelectableSize)

This also might have side effects due to margins?


More information about the webkit-reviews mailing list