[webkit-reviews] review denied: [Bug 78599] Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel : [Attachment 126964] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 05:32:06 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 78599: Web Inspector: [refactoring] extract TimelineOverviewWindow from
TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599

Attachment 126964: Patch
https://bugs.webkit.org/attachment.cgi?id=126964&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126960&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:196
> +    this._parent = parentElement;

this._parentElement

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:237
> +    scrollWindow: function(event)

Could you leave it in place for the sake of better diff?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:261
> +	       if (node.hasStyleClass("resources-dividers-label-bar")) {

why did this change?


More information about the webkit-reviews mailing list