[webkit-reviews] review denied: [Bug 21570] Elements panel needs to be able to preview images : [Attachment 126930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 14 01:23:22 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 21570: Elements panel needs to be able to preview images
https://bugs.webkit.org/show_bug.cgi?id=21570

Attachment 126930: Patch
https://bugs.webkit.org/attachment.cgi?id=126930&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126930&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:721
> +		   this._dimensions = { offsetWidth: properties[0],
offsetHeight: properties[1], naturalWidth: properties[2], naturalHeight:
properties[3] };

You should place all the functionality into the same place, there is no need to
place some of it here and the other part in the panel.


More information about the webkit-reviews mailing list