[webkit-reviews] review denied: [Bug 78581] [chromium] [WebSocket] Add static SocketStreamHandleInternal::toWebSocketStreamHandle function : [Attachment 126918] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 14 01:07:37 PST 2012
Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 78581: [chromium] [WebSocket] Add static
SocketStreamHandleInternal::toWebSocketStreamHandle function
https://bugs.webkit.org/show_bug.cgi?id=78581
Attachment 126918: Patch
https://bugs.webkit.org/attachment.cgi?id=126918&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126918&action=review
> Source/WebKit/chromium/ChangeLog:3
> + Provide
SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
You need to explain why you want to change so in ChangeLog.
> Source/WebKit/chromium/src/SocketStreamHandleInternal.h:1
> +/*
We need to add new header file to build files such as gyp, project.pbxproj,
etc.
More information about the webkit-reviews
mailing list