[webkit-reviews] review denied: [Bug 78455] Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot() : [Attachment 126896] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78455: Use youngestShadowRoot and oldestShadowRoot instead of
Element::shadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=78455

Attachment 126896: Patch
https://bugs.webkit.org/attachment.cgi?id=126896&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126896&action=review


> Source/WebCore/dom/Element.cpp:1181
> +#endif

We can remove this.

> Source/WebCore/dom/ShadowRootList.cpp:93
> +{

Is it safe to attach like this?

> Source/WebCore/html/InputType.cpp:387
> +	       root->removeChild(root->firstChild());

Why not removeAllChildren()?