[webkit-reviews] review requested: [Bug 78513] If memset gets inlined at WebKit/Source/JavaScriptCore/wtf/Vector.h, it may produce a warning : [Attachment 126899] Should not have any runtime overhead with this patch at -O2.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 20:26:54 PST 2012
asharif.tools at gmail.com has asked for review:
Bug 78513: If memset gets inlined at WebKit/Source/JavaScriptCore/wtf/Vector.h,
it may produce a warning
https://bugs.webkit.org/show_bug.cgi?id=78513
Attachment 126899: Should not have any runtime overhead with this patch at -O2.
https://bugs.webkit.org/attachment.cgi?id=126899&action=review
------- Additional Comments from asharif.tools at gmail.com
This patch is now checking if dstEnd - dst is a constant before doing the 0
check. If dstEnd - dst is not a constant, the first part of the if condition is
true and the whole if condition should be folded away.
More information about the webkit-reviews
mailing list