[webkit-reviews] review granted: [Bug 78422] Convert svg/animations to use SMIL methods for driving the timeline : [Attachment 126652] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 78422: Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422

Attachment 126652: Patch
https://bugs.webkit.org/attachment.cgi?id=126652&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126652&action=review


> Source/WebCore/ChangeLog:19
> +	     via beginElement/endElement - get removed if the begin/endTImes
list is updated. Why?

typo: s/endTImes/endTimes/

> Source/WebCore/ChangeLog:30
> +	   - document.getElementsByTagName('animateMotion')[0], always returned
'object SVGElement', instead of

Normally this would be another bug report :)

> Source/WebCore/ChangeLog:32
> +	     from SVGANimationElement were not available. Fix that by removing
the last hacks from svgtags.in,

s/SVGANimationElement/SVGAnimationElement/

> Source/WebCore/ChangeLog:70
> +	   * svg/svgtags.in: Enable animateMotion/hkern/mpath JS interfaces,
which were not enabled, despite their IDLs existed.

Another bug report.. normally ;) Do you test them?

> LayoutTests/svg/animations/resources/SVGAnimationTestCase.js:77
> +    // We still have to name this function runRepaintTest(), as
svg/dynamic-updates/

? where is repaintTest?