[webkit-reviews] review granted: [Bug 78541] [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets : [Attachment 126859] with more ChangeLog

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 78541: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541

Attachment 126859: with more ChangeLog
https://bugs.webkit.org/attachment.cgi?id=126859&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126859&action=review


> LayoutTests/http/tests/websocket/tests/hixie76/alert-in-event-handler.html:14

>  window.jsTestIsAsync = true;
> +if (window.layoutTestController)
> +   
layoutTestController.overridePreference("WebKitHixie76WebSocketProtocolEnabled"
, 1);

IMO, we had better skip the hixie76 tests on platforms which enabled the RFC
protocol in order to reduce testing time.
Anyway, this change is correct.