[webkit-reviews] review granted: [Bug 78550] Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass : [Attachment 126865] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 16:47:15 PST 2012
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 78550: Implement enough of ChromiumAndroidPort to make
ChromiumAndroidPortTest pass
https://bugs.webkit.org/show_bug.cgi?id=78550
Attachment 126865: Patch
https://bugs.webkit.org/attachment.cgi?id=126865&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126865&action=review
> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:154
> + def _build_path(self, *comps):
> + return self._host_port._build_path(*comps)
> +
> + def _path_to_apache(self):
> + return self._host_port._path_to_apache()
> +
> + def _path_to_apache_config_file(self):
> + return self._host_port._path_to_apache_config_file()
I suspect we'll eventually want some sort of HostedPort.
More information about the webkit-reviews
mailing list