[webkit-reviews] review granted: [Bug 78515] DFG should be able to emit code on control flow edges : [Attachment 126816] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 78515: DFG should be able to emit code on control flow edges
https://bugs.webkit.org/show_bug.cgi?id=78515

Attachment 126816: the patch
https://bugs.webkit.org/attachment.cgi?id=126816&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126816&action=review


> Source/JavaScriptCore/assembler/MacroAssembler.h:78
> +    static DoubleCondition invert(DoubleCondition cond)

At some point we should probably make double condition a common type for all
assemblers (independent of machine implementation), with a guarantee that we
can just invert by flipping a bit, and sue a table to map from the abstract
type to a machine type.  Ditto for the integer conditions.  This looks fine for
now though.

> Source/JavaScriptCore/assembler/MacroAssembler.h:110
> +    static bool isInvertible(ResultCondition cond)

Presumably we could do away with this by introducing NoOverflow/NotSigned
types? Probably worth doing at some point, though not urgent.