[webkit-reviews] review denied: [Bug 78532] Last character display for passwords in Android. : [Attachment 126835] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ramya Chandrasekaran
<cramya at chromium.org>'s request for review:
Bug 78532: Last character display for passwords in Android.
https://bugs.webkit.org/show_bug.cgi?id=78532

Attachment 126835: Patch
https://bugs.webkit.org/attachment.cgi?id=126835&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126835&action=review


The rest of the change looks fine.

> Source/WebCore/page/Settings.cpp:233
> +#if OS(ANDROID)
> +    , m_passwordEchoEnabled(true)
> +#else
>      , m_passwordEchoEnabled(false)
> +#endif

This isn't correct.  The Android should change this preference via the Chromium
WebKit API.  We use the same initializations across all the ports.