[webkit-reviews] review granted: [Bug 78527] [chromium] CSS Filters on accelerated layers: Brightness and Contrast don't work, Saturation is wrong : [Attachment 126824] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 78527: [chromium] CSS Filters on accelerated layers:  Brightness and
Contrast don't work, Saturation is wrong
https://bugs.webkit.org/show_bug.cgi?id=78527

Attachment 126824: Patch
https://bugs.webkit.org/attachment.cgi?id=126824&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126824&action=review


Looks good to me though I'm no expert on the math. Couple of minor nits.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:43
> +    memset(matrix, 0, 20 * sizeof(SkScalar));

Instead of "20 * sizeof(SkScalar)" how about just sizeof(matrix)?

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:58
> +    memset(matrix, 0, 20 * sizeof(SkScalar));

Same here.