[webkit-reviews] review denied: [Bug 78136] Initial upstreaming of selection handling code for BlackBerry port : [Attachment 126821] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 78136: Initial upstreaming of selection handling code for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78136

Attachment 126821: Patch
https://bugs.webkit.org/attachment.cgi?id=126821&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126821&action=review


Almost there, just a few things to fix.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:46
> +#include <BlackBerryPlatformIntRectRegion.h>

already included in header.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:141
> +

Maybe remove the empty line.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:608
> +    ASSERT(m_webPage && m_inputHandler);

you probably mean m_webPage->m_inputHandler.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h:34
> +class TextGranularity;

Not needed.