[webkit-reviews] review granted: [Bug 76867] nesting horizontal flexboxes is broken : [Attachment 126398] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 13:16:12 PST 2012
Dave Hyatt <hyatt at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76867: nesting horizontal flexboxes is broken
https://bugs.webkit.org/show_bug.cgi?id=76867
Attachment 126398: Patch
https://bugs.webkit.org/attachment.cgi?id=126398&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126398&action=review
r=me, with the rename suggestion for the static method below.
> Source/WebCore/rendering/RenderFlexibleBox.cpp:159
> +static LayoutUnit marginWidthForChild(RenderBox* child, RenderStyle*
parentStyle)
Should be marginLogicalWidthForChild.
More information about the webkit-reviews
mailing list