[webkit-reviews] review denied: [Bug 78136] Initial upstreaming of selection handling code for BlackBerry port : [Attachment 126786] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 78136: Initial upstreaming of selection handling code for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78136

Attachment 126786: Patch
https://bugs.webkit.org/attachment.cgi?id=126786&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126786&action=review


Looks good, some things still need fixing.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:58
> +using namespace WebCore;

This means you can get rid of all the WebCore:: prefixes below.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:316
> +	   // Extend x to bottom without modifying x.

Extend y?

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:646
> +    if (renderer)

You can do if (RenderObject* renderer =  ... ) here

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h:68
> +    void caretPositionChanged();

caretPositionChanged should be private, it is not used outside of
SelectionHandler.