[webkit-reviews] review granted: [Bug 78498] [chromium] Set opaque flag on SkBitmap in per-tile layer updater : [Attachment 126773] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 09:40:59 PST 2012
Stephen White <senorblanco at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 78498: [chromium] Set opaque flag on SkBitmap in per-tile layer updater
https://bugs.webkit.org/show_bug.cgi?id=78498
Attachment 126773: Patch
https://bugs.webkit.org/attachment.cgi?id=126773&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126773&action=review
Looks good. r=me
>>>
Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
52
>>> +
>>
>> Out of curiosity, why does this need to be public now? It doesn't seem to
be called from anywhere new.
>
> It should have been public to start with. The function its overriding in
LayerTextureUpdater.h is public.
Ah, thanks for the explanation.
More information about the webkit-reviews
mailing list