[webkit-reviews] review granted: [Bug 78340] Add WindowsExtras.h : [Attachment 126484] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 13 07:30:12 PST 2012


Adam Roben (:aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 78340: Add WindowsExtras.h
https://bugs.webkit.org/show_bug.cgi?id=78340

Attachment 126484: Patch
https://bugs.webkit.org/attachment.cgi?id=126484&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126484&action=review


> Source/WebCore/platform/win/WindowsExtras.h:32
> +inline void* getWindowPointer(HWND hWnd, int index = 0)

I think it would be clearer to make index a required parameter. (Ditto for the
setter.)


More information about the webkit-reviews mailing list