[webkit-reviews] review granted: [Bug 75217] [Forms] Use enum instead of bool for HTMLInputElement::setValue : [Attachment 126736] Patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 01:26:31 PST 2012
Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 75217: [Forms] Use enum instead of bool for HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=75217
Attachment 126736: Patch 4
https://bugs.webkit.org/attachment.cgi?id=126736&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126736&action=review
ok
> Source/WebCore/html/RangeInputType.cpp:224
> - bool sendChangeEvent = true;
> - setValueAsNumber(newValue, sendChangeEvent, ec);
> + TextFieldEventBehavior eventBehavior = DispatchChangeEvent;
> + setValueAsNumber(newValue, eventBehavior, ec);
nit: We can remove the 'eventBehavior' variable.
More information about the webkit-reviews
mailing list