[webkit-reviews] review denied: [Bug 75217] [Forms] Use enum instead of bool for HTMLInputElement::setValue : [Attachment 126735] Patch 3

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 75217: [Forms] Use enum instead of bool for HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=75217

Attachment 126735: Patch 3
https://bugs.webkit.org/attachment.cgi?id=126735&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126735&action=review


> Source/WebCore/html/RadioInputType.cpp:160
> -#if PLATFORM(IOS)
> -    state->indeterminate = element()->indeterminate();
> -
>      if (element()->indeterminate())
>	   element()->setIndeterminate(false);
> -#endif
> -
> -    element()->setChecked(true, true);
> +    element()->setChecked(true, DispatchChangeEvent);
>  

please do not remove unrelated code.

> Source/WebCore/html/RadioInputType.cpp:-185
> -
> -#if PLATFORM(IOS)	    
>	   element()->setIndeterminate(state.indeterminate);
> -#endif
> -

ditto.

> Source/WebCore/html/RadioInputType.cpp:-203
> -#if PLATFORM(IOS)
>      return true;
> -#else
> -    return false;
> -#endif

ditto.