[webkit-reviews] review denied: [Bug 78460] [WebSocket] Add owner Frame* as an argument to SocketStreamHandle::create, etc : [Attachment 126722] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 78460: [WebSocket] Add owner Frame* as an argument to
SocketStreamHandle::create, etc
https://bugs.webkit.org/show_bug.cgi?id=78460

Attachment 126722: Patch
https://bugs.webkit.org/attachment.cgi?id=126722&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126722&action=review


> Source/WebCore/ChangeLog:8
> +	   Add owner Frame* as an argument to SocketStreamHandle::create, etc
> +	   https://bugs.webkit.org/show_bug.cgi?id=78460
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests because of just adding an unsed argument.

Please write reasons why you add an unused argument.

> Source/WebCore/websockets/WebSocketChannel.cpp:143
> +    Document* document = static_cast<Document*>(m_context);

Is this cast safe?  Can't m_context be a worker?