[webkit-reviews] review granted: [Bug 78461] Move attribute style invalidation to attributeChanged(). : [Attachment 126719] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 78461: Move attribute style invalidation to attributeChanged().
https://bugs.webkit.org/show_bug.cgi?id=78461

Attachment 126719: Patch
https://bugs.webkit.org/attachment.cgi?id=126719&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=126719&action=review


> Source/WebCore/html/HTMLPreElement.cpp:52
> +void HTMLPreElement::collectStyleForAttribute(Attribute* attr,
StylePropertySet* style)

collectStyleForAttribute() should be renamed to
collectStyleForPresentationAttribute() to match isPresentationAttribute()

> Source/WebCore/html/HTMLTableElement.cpp:359
> +    if (attr->name() == widthAttr || attr->name() == heightAttr ||
attr->name() == bgcolorAttr || attr->name() == backgroundAttr || attr->name()
== valignAttr || attr->name() == vspaceAttr || attr->name() == hspaceAttr ||
attr->name() == alignAttr || attr->name() == cellspacingAttr || attr->name() ==
borderAttr || attr->name() == bordercolorAttr || attr->name() == frameAttr ||
attr->name() == rulesAttr)

Uh, this line is pretty long.