[webkit-reviews] review granted: [Bug 78140] Add toText and isTextNode helpers in Text class : [Attachment 126692] UnitTestCase-StyleChecker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 12 17:49:24 PST 2012


Adam Barth <abarth at webkit.org> has granted Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 78140: Add toText and isTextNode helpers in Text class
https://bugs.webkit.org/show_bug.cgi?id=78140

Attachment 126692: UnitTestCase-StyleChecker
https://bugs.webkit.org/attachment.cgi?id=126692&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126692&action=review


> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:762
> +    # Test for static_cast readability.

This comment doesn't seem to be adding any value.  It's redundant with the
function name.


More information about the webkit-reviews mailing list