[webkit-reviews] review granted: [Bug 78091] [EFL][DRT] Implement zoomPage{In, Out} and textZoom{In, Out} events. : [Attachment 126248] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 78091: [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
https://bugs.webkit.org/show_bug.cgi?id=78091

Attachment 126248: Patch
https://bugs.webkit.org/attachment.cgi?id=126248&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review


I recommend to split the patch into code-only part and rebaselining until efl
DRT is available on the bot.
Rebaselining is kinda semi automatic stuff but the code change is not.

> Tools/DumpRenderTree/efl/EventSender.cpp:454
> +static void textZoom(bool zoomIn)

Enum would be better in these case.

> Tools/DumpRenderTree/efl/EventSender.cpp:469
> +static void pageZoom(bool zoomIn)

Enum would be better in these case.