[webkit-reviews] review granted: [Bug 77718] SharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK is defined : [Attachment 125422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 11 21:41:48 PST 2012
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 77718: SharedBuffer::getSomeData() must support m_dataArray if
NETWORK_CFDATA_ARRAY_CALLBACK is defined
https://bugs.webkit.org/show_bug.cgi?id=77718
Attachment 125422: Patch
https://bugs.webkit.org/attachment.cgi?id=125422&action=review
------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125422&action=review
r=me
>> Source/WebCore/platform/SharedBuffer.cpp:261
>> + someData = m_segments[segment] + positionInSegment;
>
> ASSERT(segment < m_segments.size());
This is a redundant ASSERT(). It will always be true inside this if statement
because it's already checking (segment < segments) and segments =
m_segments.size().
> Source/WebCore/platform/SharedBuffer.cpp:269
> +#endif
> + ASSERT_NOT_REACHED();
> + return 0;
The last part of this method should be in an #else/#endif clause:
#else
ASSERT_NOT_REACHED();
return 0;
#endif
> Source/WebCore/platform/cf/SharedBufferCF.cpp:121
> + Vector<RetainPtr<CFDataRef> >::const_iterator end = m_dataArray.end();
Nit: Might be nice to have a typedef for Vector<RetainPtr<CFDataRef> >.
More information about the webkit-reviews
mailing list