[webkit-reviews] review denied: [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units : [Attachment 126385] Patch-updated-I
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 11 12:33:45 PST 2012
Antti Koivisto <koivisto at iki.fi> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 27160: Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160
Attachment 126385: Patch-updated-I
https://bugs.webkit.org/attachment.cgi?id=126385&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=126385&action=review
> Source/WebCore/platform/Length.h:308
> + unsigned char m_viewportLengthType;
> + Document *m_document;
You can't add this stuff to Length. It is a memory-critical basic type.
More information about the webkit-reviews
mailing list